-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend refactor to API-based model and NodeJS GUI implementation #956
Draft
patel-nikhil
wants to merge
58
commits into
UnofficialCrusaderPatch:ucp2-development
Choose a base branch
from
patel-nikhil:nodejsgui
base: ucp2-development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Backend refactor to API-based model and NodeJS GUI implementation #956
patel-nikhil
wants to merge
58
commits into
UnofficialCrusaderPatch:ucp2-development
from
patel-nikhil:nodejsgui
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patel-nikhil
force-pushed
the
nodejsgui
branch
from
December 24, 2021 06:33
2af6f70
to
97220f1
Compare
Note:
|
…o unpacked GUI application folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UCP.Model.ModUIConfig
class (where aMod
represents a top-level (potentially grouped) selection that can be made by the user) and aModUIConfig
instance represents all the information needed by the frontend (and passed from the backend) in order to present the user with a visual way to select option(s) for the given Mod.Note: the
Startup
class andInvoke
method will be ideally be renamed in upcoming commits. Returning aTask<object>
delegate is required to expose a non-blocking implementation to a callee (ie. NodeJS) however with current implementation the config retrieval is synchronousNote: GUI uses NodeJS, TypeScript, Electron, Webpack. Entry (startup) file is the
unofficialcrusaderpatch-gui\index.ts
. Can be started via Visual Studio or simply usingnpm run build
or (identical)npm start
(fromunofficialcrusaderpatch-gui
directory)Requires NodeJS support to be installed if using Visual Studio (VS 2019)
Requires npm and NodeJS to be installed if using npm commands directly. Use
npm ci
overnpm install
to ensure you are using the same versions of dependencies as specified in thepackage-lock.json
fileNote: webpack integration is mostly working however sometimes there is a dev tools disconnect on load & reload. If after running the project you get a blank screen and/or message in dev tools saying disconnected, then close dev tools and force reload the app (Ctrl + R, same command as if refreshing a web page)