Client instance service #5126
Merged
Client instance service #5126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
…-instance-service
FredrikOseberg
approved these changes
Oct 23, 2023
Comment on lines
+168
to
+178
| schedulerService.schedule( | ||
| clientInstanceService.bulkAdd.bind(clientInstanceService), | ||
| secondsToMilliseconds(5), | ||
| 'bulkAddInstances', | ||
| ); | ||
|
|
||
| schedulerService.schedule( | ||
| clientInstanceService.announceUnannounced.bind(clientInstanceService), | ||
| minutesToMilliseconds(5), | ||
| 'announceUnannounced', | ||
| ); |
There was a problem hiding this comment.
Where these previously configurable by environment variables? Or were the parameters in instance-service.ts never used?
There was a problem hiding this comment.
They were default parameters on the constructor that never got overwritten in prod, only in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Moved client instance scheduling to a scheduler service + simplified testing
Important files
Discussion points