fix: don't clean up settings when optional data is not present #5118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gastonfournier
commented
Oct 23, 2023
Comment on lines
+271
to
+272
| // updated project contains instructions to update the project but it may not represent a whole project | ||
| const afterData = await this.projectStore.get(updatedProject.id); |
There was a problem hiding this comment.
Without this, our diff is a bit misleading:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This fixes a bug updating a project, when optional data (defaultStickiness and featureLimit are not part of the payload).
Example:
Then if you try to get the project with a PAT, the API will return a 403. The reason is that the project mode gets cleared (mode=null) because of the following update statement that does not check if defaultStickiness or featureLimit are present, resulting in an update without fields that clears the table https://github.com/Unleash/unleash/blob/main/src/lib/db/project-store.ts#L268-L281
Note that the project still exists, and this can be checked using the initial admin token:
curl http://localhost:4242/api/admin/projects/default -H 'Authorization: *:*.unleash-insecure-admin-api-token'The problem happens due to:
additional properties: true, which is what we agreed on for input)