fix: grey out text and icons for disabled strategies in playground #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Signed-off-by: andreas-unleash <[email protected]>
andreas-unleash
commented
Oct 20, 2023
| @@ -71,7 +71,7 @@ export const StrategyExecution: VFC<IStrategyExecutionProps> = ({ | |||
| // biome-ignore lint/suspicious/noArrayIndexKey: <explanation> | |||
| <Fragment key={index}> | |||
| <ConditionallyRender | |||
| condition={index > 0} | |||
| condition={index > 0 && (strategyResult.name === 'flexibleRollout' ? index < items.length : index < items.length -1) } | |||
There was a problem hiding this comment.
We seem to have a trailing AND - this fixes it
Signed-off-by: andreas-unleash <[email protected]>
Comment on lines
27
to
28
| const r = 100 / (2 * Math.PI); | ||
| const d = 2 * r; |
There was a problem hiding this comment.
Can we use full names here please? Radius and diameter are much more readable than r & d.
FredrikOseberg
approved these changes
Oct 20, 2023
Signed-off-by: andreas-unleash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin
Closes # 1-1512
