Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ts-ignore and adapt tests #5103

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

gastonfournier
Copy link
Contributor

About the changes

Just using proper types and adapting a few tests

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 2:18pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Oct 19, 2023 2:18pm


expect(users).toHaveLength(2);
expect(users).toHaveLength(3); // the 2 added plus the one that created the project
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @chriswk as you're the last to edit this test, it was 2 because when creating a project with an invalid user (one without an id), the code will just ignore adding the user as owner without failing:

// TODO: remove this when all users is guaranteed to have a unique id.
if (owner.id) {
this.logger.info(
`Making ${owner.id} admin of ${projectId} via roleId=${ownerRole.id}`,
);
await this.store.addUserToRole(owner.id, ownerRole.id, projectId);
}

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gastonfournier gastonfournier merged commit b5d9bba into main Oct 19, 2023
14 checks passed
@gastonfournier gastonfournier deleted the remove-ts-ignore-from-e2e-test branch October 19, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants