Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deepDiff #5082

Closed
wants to merge 1 commit into from
Closed

fix: remove deepDiff #5082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 0 additions & 66 deletions src/lib/features/feature-toggle/deep-diff.ts
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions src/lib/features/feature-toggle/feature-toggle-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,6 @@ import { IPrivateProjectChecker } from '../private-project/privateProjectChecker
import { IDependentFeaturesReadModel } from '../dependent-features/dependent-features-read-model-type';
import EventService from '../../services/event-service';
import { DependentFeaturesService } from '../dependent-features/dependent-features-service';
import isEqual from 'lodash.isequal';
import { deepDiff } from './deep-diff';

interface IFeatureContext {
featureName: string;
Expand Down Expand Up @@ -1062,22 +1060,6 @@ class FeatureToggleService {
),
]);

const equal = isEqual(
featuresFromClientStore,
featuresFromFeatureToggleStore,
);

if (!equal) {
const difference = deepDiff(
featuresFromClientStore,
featuresFromFeatureToggleStore,
);
this.logger.warn(
'getPlaygroundFeatures: features from client-feature-toggle-store is not equal to features from feature-toggle-store',
difference,
);
}

const features = this.flagResolver.isEnabled('separateAdminClientApi')
? featuresFromFeatureToggleStore
: featuresFromClientStore;
Expand Down Expand Up @@ -1113,22 +1095,6 @@ class FeatureToggleService {
),
]);

const equal = isEqual(
featuresFromClientStore,
featuresFromFeatureToggleStore,
);

if (!equal) {
const difference = deepDiff(
featuresFromClientStore,
featuresFromFeatureToggleStore,
);
this.logger.warn(
'getFeatureToggles: features from client-feature-toggle-store is not equal to features from feature-toggle-store diff',
difference,
);
}

const features = this.flagResolver.isEnabled('separateAdminClientApi')
? featuresFromFeatureToggleStore
: featuresFromClientStore;
Expand Down
61 changes: 0 additions & 61 deletions src/lib/features/feature-toggle/tests/deep-diff.test.ts
View file
Open in desktop

This file was deleted.

Loading