feat: add option to return disabled strategies #5059
Conversation
Signed-off-by: andreas-unleash <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: andreas-unleash <[email protected]>
Signed-off-by: andreas-unleash <[email protected]>
| if ( | ||
| this.isUnseenStrategyRow(feature, row) && | ||
| (includeDisabledStrategies ? true : !row.strategy_disabled) | ||
| ) { |
There was a problem hiding this comment.
I don't think this is the correct place to put this. createBaseFeature should only care about what is common between the two API endpoints. Instead you should take this check and move into the respective methods: buildFeatureToggleListFromRows and buildPlaygroundFeaturesFromRows and have each method have different checks for which strategies they allow
There was a problem hiding this comment.
Ok makes sense
There was a problem hiding this comment.
Turns out that both of those functions are only used for the Admin API - for which we (everywhere) return the disabled strategies
Signed-off-by: andreas-unleash <[email protected]>
| if ( | ||
| this.isUnseenStrategyRow(feature, r) && | ||
| includeDisabledStrategies && | ||
| r.strategy_disabled | ||
| ) { | ||
| feature.strategies?.push(this.rowToStrategy(r)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why does the feature toggle list need disabled strategies?
There was a problem hiding this comment.
Maybe I am misunderstanding something here. Following the calls
featureToggleRowConverter.buildFeatureToggleListFromRows is called from
featureToggleStore.getFeatureToggleList is called from
featureToggleService.getFeatureTogglesis called from
featureToggleLegacyController.getAllToggles that is initialised from the AdminApi.
I added it because of following up to the Admin api admin/features
There was a problem hiding this comment.
Following to the frontend - the disabled strategies are not needed
Signed-off-by: andreas-unleash <[email protected]>
|
Not only relevant to playground. To be more specific - this is needed for the admin api |
andreas-unleash
deleted the
feat/return_disabled_strategies_to_playground
branch
Adds the option to include disabled strategies (behind the playgroundImprovements flag
Closes # 1-1505