ui: add splash screen for oss segments #5053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Because this will run in OSS installations, the feature flag will always be false (because it doesn't connect to our systems)
thomasheartman
changed the title
kwasniew
reviewed
Oct 17, 2023
nunogois
reviewed
Oct 17, 2023
…ashScreen.tsx Co-authored-by: Nuno Góis <[email protected]>
|
Found a visual glitch in non-oss versions (it's in the vercel preview). Seems like the splash gets rendered initially before getting turned off. Could it be that the |
|
Interestingly, I'm not able to replicate it locally, so this'll be a little tricky. |
|
But yeah, this line is probably why: const isOss = useCallback(() => {
return !data?.versionInfo?.current?.enterprise;
}, [data]);So before we get data, I'm assuming we're counting everything as OSS. I wonder if that's the right approach? Probably fine 💁🏼 update: |
thomasheartman
added a commit
that referenced
this pull request
Oct 19, 2023
This PR adds a splash screen for segments being open-sourced. It looks like this:  ## About the changes I've more or less wholesale copied the demo dialog that @nunogois implemented. I've put it in the `splash` directory for now (because that's where it seemed most appropriate). The reason for straight copying it instead of extending existing functionality is primarily that this should be short-lived and deleted after the next release or so. So isolating all the changes into a single directory seems like a good idea. ## Discussion points Because OSS installations don't connect to Unleash, we can't use feature flags to control the rollout here. Instead, we must just assume that OSS users will want to see it. If there is a better way we can control this, that'd be great. I'd love to be able to use time constraints to not show this after a certain date, for instance, but I don't think that's something we can do right now? The splash is also set to display on any page you're at when you first load unleash. However, closing the dialog (either by closing or by asking to see segments) will store that in localstorage, and you won't be shown the dialog again. --------- Co-authored-by: Nuno Góis <[email protected]>
thomasheartman
added a commit
that referenced
this pull request
Oct 19, 2023
This PR adds a splash screen for segments being open-sourced. It looks like this:  ## About the changes I've more or less wholesale copied the demo dialog that @nunogois implemented. I've put it in the `splash` directory for now (because that's where it seemed most appropriate). The reason for straight copying it instead of extending existing functionality is primarily that this should be short-lived and deleted after the next release or so. So isolating all the changes into a single directory seems like a good idea. ## Discussion points Because OSS installations don't connect to Unleash, we can't use feature flags to control the rollout here. Instead, we must just assume that OSS users will want to see it. If there is a better way we can control this, that'd be great. I'd love to be able to use time constraints to not show this after a certain date, for instance, but I don't think that's something we can do right now? The splash is also set to display on any page you're at when you first load unleash. However, closing the dialog (either by closing or by asking to see segments) will store that in localstorage, and you won't be shown the dialog again. --------- Co-authored-by: Nuno Góis <[email protected]> --------- Co-authored-by: Nuno Góis <[email protected]>
thomasheartman
added a commit
that referenced
this pull request
Nov 17, 2023
This change removes the oss segments splash screen that was introduced in #5053.
thomasheartman
added a commit
that referenced
this pull request
Nov 17, 2023
This change removes the oss segments splash screen that was introduced in #5053.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a splash screen for segments being open-sourced.
It looks like this:
About the changes
I've more or less wholesale copied the demo dialog that @nunogois implemented. I've put it in the
splashdirectory for now (because that's where it seemed most appropriate). The reason for straight copying it instead of extending existing functionality is primarily that this should be short-lived and deleted after the next release or so. So isolating all the changes into a single directory seems like a good idea.Discussion points
Because OSS installations don't connect to Unleash, we can't use feature flags to control the rollout here. Instead, we must just assume that OSS users will want to see it. If there is a better way we can control this, that'd be great. I'd love to be able to use time constraints to not show this after a certain date, for instance, but I don't think that's something we can do right now?
The splash is also set to display on any page you're at when you first load unleash. However, closing the dialog (either by closing or by asking to see segments) will store that in localstorage, and you won't be shown the dialog again.