Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show dependencies only when using pro/enterprise or at least on… #5052

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Oct 16, 2023

About the changes

Dependent features makes UI more complicated. OSS usually needs simpler feature set so this feature will be disabled for them unless one dependency already exists in the system.

We're only hiding this part of the UI since it's the only way to create a new dependency
Screenshot 2023-10-16 at 14 27 39

Impl details:

  • added backend route for checking if any dependencies exists
  • added frontend hook that looks at a flag and makes API call to check if any dependencies exist
  • added backend and frontend tests

Important files

Discussion points

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 2:16pm
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 2:16pm

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwasniew kwasniew merged commit e9e110f into main Oct 16, 2023
13 of 14 checks passed
@kwasniew kwasniew deleted the show-dependencies-for-pro-enterprise branch October 16, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants