Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track add and remove dependencies #5041

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

kwasniew
Copy link
Contributor

About the changes

Track when adding/removing dependencies in regular mode and change request mode.

Important files

Discussion points

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 8:09am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Oct 16, 2023 8:09am

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One minor note about the change request events, but that's entirely optional.

Comment on lines +129 to +130
? 'add dependency added to change request'
: 'delete dependency added to change request',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor thing, but these two are a little confusing at first. Maybe we can rephrase them a bit?

Something like "dependency added in change request" and "dependency removed in change request"? Or "dependency added (change request)"/"dependency removed (change request)". Or we could use multiple props? Something like this:

eventType: 'dependency added',
where: 'change request'

Primarily to avoid the "add x added" or "delete x added". But eh, as long as we understand what we're talking about I think it's fine 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about it myself. Originally I wanted to say "dependency added in change requests" but it's actually not true. We're only adding "add dependency" change to a change request. We'll know that dependency was added in change request once we apply the change request which may never happen.

@kwasniew kwasniew merged commit 092ba2a into main Oct 16, 2023
14 checks passed
@kwasniew kwasniew deleted the dependency-managment-tracking branch October 16, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants