Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove last seen by env #4660

Closed
wants to merge 1 commit into from
Closed

fix: remove last seen by env #4660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/lib/db/feature-toggle-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,17 +175,17 @@ export default class FeatureToggleStore implements IFeatureToggleStore {
try {
for (const env of Object.keys(environmentArrays)) {
const toggleNames = environmentArrays[env];
await this.db(FEATURE_ENVIRONMENTS_TABLE)
.update({ last_seen_at: now })
.where('environment', env)
.whereIn(
'feature_name',
this.db(FEATURE_ENVIRONMENTS_TABLE)
.select('feature_name')
.whereIn('feature_name', toggleNames)
.forUpdate()
.skipLocked(),
);
// await this.db(FEATURE_ENVIRONMENTS_TABLE)
// .update({ last_seen_at: now })
// .where('environment', env)
// .whereIn(
// 'feature_name',
// this.db(FEATURE_ENVIRONMENTS_TABLE)
// .select('feature_name')
// .whereIn('feature_name', toggleNames)
// .forUpdate()
// .skipLocked(),
// );

// Updating the toggle's last_seen_at also for backwards compatibility
await this.db(TABLE)
Expand Down
Loading