ui: update design for feature naming pattern info #4656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kwasniew
approved these changes
Sep 12, 2023
| @@ -147,47 +139,16 @@ const FeatureForm: React.FC<IFeatureToggleForm> = ({ | |||
|
|
|||
| return ( | |||
| <StyledForm onSubmit={handleSubmit}> | |||
| <StyledContainer> | |||
| <div> | |||
There was a problem hiding this comment.
what's the purpose of this div? can we remove it?
There was a problem hiding this comment.
Unfortunately no. Well, at least not without changing something else. Due to the way the StyledForm is styled, it'll look wonky if we remove the div (I tried). That said, it's probably not hard to fix, so I'd be happy to have a look at it if you think it's a good idea.
There was a problem hiding this comment.
No, sorry, we can actually! 😄
There was a problem hiding this comment.
(adds a bunch more lines to the diff, but that's only due to indentation change)
thomasheartman
added a commit
that referenced
this pull request
Sep 13, 2023
This PR updates the UI to reflect the changes to the implicit ^ and $ that we now add. The changes are: 1. Show input adornments for ^ and $ when you create a pattern. 2. Mention that ^ and $ are added implicitly in description. 3. Checks the example you provide against the pattern with added ^ and $ + adds a test for that. Points 1 and 2:  ## Discussion point: I have not touched the information about the pattern yet as the PR that updates that is still in review (#4656), but it would be prudent to also update that info to make it clearer. I can address that in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the design for the feature naming pattern info. In doing so, I've extracted the information into a single component.
It also, on @nicolaesocaciu's behest, makes the new toggle form inputs wider when they have room to grow.
Light mode:
Dark mode:
For copying features it looks like this: