fix: multi project roles UI improvements #4646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
daveleek
reviewed
Sep 8, 2023
Comment on lines
+493
to
+495
| {selectedRow && selectedRow.entity.roles.length > 1 | ||
| ? 'Roles:' | ||
| : 'Role:'} |
There was a problem hiding this comment.
Will there always be >= 1 roles? Or could selectedRow.entity.roles.length be 0 and should it then say "Roles:" if there are 0 roles in selectedRow.entity.roles ?
There was a problem hiding this comment.
I think this is safe. This is shown inside project access and only when you click in a group that has access, which means the group should have a role. Worst case scenario it would display "Role: ", which doesn't sound super bad.
daveleek
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-1373/small-ui-fixes-and-improvements
HelpIcontooltip to reflect the new behavior;descriptioncould beundefined;RoleDescriptiondesign;ProjectGroupView;