Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/instance health #4586

Merged
merged 7 commits into from
Aug 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontend/src/component/admin/Admin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import UsersAdmin from './users/UsersAdmin';
import NotFound from 'component/common/NotFound/NotFound';
import { AdminIndex } from './AdminIndex';
import { AdminTabsMenu } from './menu/AdminTabsMenu';
import { InstanceHealth } from './instance-health/InstanceHealth';

export const Admin = () => {
return (
Expand All @@ -34,6 +35,7 @@ export const Admin = () => {
<Route path="groups/*" element={<GroupsAdmin />} />
<Route path="roles/*" element={<Roles />} />
<Route path="instance" element={<InstanceAdmin />} />
<Route path="instance-health" element={<InstanceHealth />} />
<Route path="network/*" element={<Network />} />
<Route path="maintenance" element={<MaintenanceAdmin />} />
<Route path="cors" element={<CorsAdmin />} />
Expand Down
7 changes: 7 additions & 0 deletions frontend/src/component/admin/adminRoutes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@ export const adminRoutes: INavigationMenuItem[] = [
menu: { adminSettings: true },
group: 'instance',
},
{
path: '/admin/instance-health',
title: 'Instance health',
menu: { adminSettings: true },
group: 'instance',
flag: 'instanceHealthDashboard',
},
{
path: '/admin/instance-privacy',
title: 'Instance privacy',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { useInstanceStats } from '../../../../hooks/api/getters/useInstanceStats
import { formatApiPath } from '../../../../utils/formatPath';
import { PageContent } from '../../../common/PageContent/PageContent';
import { PageHeader } from '../../../common/PageHeader/PageHeader';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';

export const InstanceStats: VFC = () => {
const { stats } = useInstanceStats();
Expand All @@ -32,6 +33,21 @@ export const InstanceStats: VFC = () => {
{ title: 'Instance Id', value: stats?.instanceId },
{ title: versionTitle, value: version },
{ title: 'Users', value: stats?.users },
{
title: 'Active past 7 days',
value: stats?.activeUsers?.last7,
offset: true,
},
{
title: 'Active past 30 days',
value: stats?.activeUsers?.last30,
offset: true,
},
{
title: 'Active past 90 days',
value: stats?.activeUsers?.last90,
offset: true,
},
{ title: 'Feature toggles', value: stats?.featureToggles },
{ title: 'Projects', value: stats?.projects },
{ title: 'Environments', value: stats?.environments },
Expand Down Expand Up @@ -64,7 +80,22 @@ export const InstanceStats: VFC = () => {
{rows.map(row => (
<TableRow key={row.title}>
<TableCell component="th" scope="row">
{row.title}
<ConditionallyRender
condition={Boolean(row.offset)}
show={
<Box
component="span"
sx={theme => ({
marginLeft: row.offset
? theme.spacing(2)
: 0,
})}
>
{row.title}
</Box>
}
elseShow={row.title}
/>
</TableCell>
<TableCell align="right">{row.value}</TableCell>
</TableRow>
Expand Down
220 changes: 220 additions & 0 deletions frontend/src/component/admin/instance-health/InstanceHealth.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,220 @@
import { VFC, useMemo } from 'react';
import { useSortBy, useTable } from 'react-table';
import { styled, Typography, Box } from '@mui/material';
import { PageContent } from 'component/common/PageContent/PageContent';
import { PageHeader } from 'component/common/PageHeader/PageHeader';
import { useInstanceStats } from 'hooks/api/getters/useInstanceStats/useInstanceStats';
import useProjects from 'hooks/api/getters/useProjects/useProjects';
import { sortTypes } from 'utils/sortTypes';
import {
SortableTableHeader,
Table,
TableBody,
TableRow,
TableCell,
} from 'component/common/Table';
import { TextCell } from 'component/common/Table/cells/TextCell/TextCell';
import { HelpPopper } from 'component/project/Project/ProjectStats/HelpPopper';
import { StatusBox } from 'component/project/Project/ProjectStats/StatusBox';
import { DateCell } from 'component/common/Table/cells/DateCell/DateCell';

interface IInstanceHealthProps {}

const CardsGrid = styled('div')(({ theme }) => ({
display: 'grid',
gridTemplateColumns: 'repeat(auto-fit, minmax(300px, 1fr))',
gap: theme.spacing(2),
paddingBottom: theme.spacing(2),
}));

const Card = styled('div')(({ theme }) => ({
padding: theme.spacing(2.5),
borderRadius: `${theme.shape.borderRadiusLarge}px`,
backgroundColor: `${theme.palette.background.paper}`,
border: `1px solid ${theme.palette.divider}`,
// boxShadow: theme.boxShadows.card,
display: 'flex',
flexDirection: 'column',
}));

/**
* @deprecated unify with project widget
*/
const StyledWidget = styled(Box)(({ theme }) => ({
position: 'relative',
padding: theme.spacing(3),
backgroundColor: theme.palette.background.paper,
flex: 1,
display: 'flex',
flexDirection: 'column',
alignItems: 'center',
justifyContent: 'center',
borderRadius: `${theme.shape.borderRadiusLarge}px`,
[theme.breakpoints.down('lg')]: {
padding: theme.spacing(2),
},
}));

export const InstanceHealth: VFC<IInstanceHealthProps> = () => {
const { stats } = useInstanceStats();
const { projects } = useProjects();
// FIXME: loading state

const initialState = useMemo(
() => ({
hiddenColumns: [],
sortBy: [{ id: 'createdAt' }],
}),
[]
);

const data = useMemo(() => projects, [projects]);

const dormantUsersPercentage =
(1 - stats?.activeUsers?.last90! / stats?.users!) * 100;

const dormantUsersColor =
dormantUsersPercentage < 30
? 'success.main'
: dormantUsersPercentage < 50
? 'warning.main'
: 'error.main';

const COLUMNS = useMemo(
() => [
{
accessor: 'name',
Header: 'Project name',
Cell: TextCell,
width: '80%',
},
{
Header: 'Feature toggles',
accessor: 'featureCount',
Cell: TextCell,
},
{
Header: 'Created at',
accessor: 'createdAt',
Cell: DateCell,
},
{
Header: 'Members',
accessor: 'memberCount',
Cell: TextCell,
},
{
Header: 'Health',
accessor: 'health',
Cell: ({ value }: { value: number }) => {
const healthRatingColor =
value < 50
? 'error.main'
: value < 75
? 'warning.main'
: 'success.main';
return (
<TextCell>
<Typography
component="span"
sx={{ color: healthRatingColor }}
>
{value}%
</Typography>
</TextCell>
);
},
},
],
[]
);

const { headerGroups, rows, prepareRow, getTableProps, getTableBodyProps } =
useTable(
{
columns: COLUMNS as any,
data: data as any,
initialState,
sortTypes,
autoResetGlobalFilter: false,
autoResetHiddenColumns: false,
autoResetSortBy: false,
disableSortRemove: true,
},
useSortBy
);

return (
<>
<CardsGrid>
<Card>
<StatusBox
title="User accounts"
boxText={String(stats?.users)}
customChangeElement={<></>}
>
{/* <HelpPopper id="user-accounts">
Sum of all configuration and state modifications in
the project.
</HelpPopper> */}
{/* FIXME: tooltip */}
</StatusBox>
</Card>
<Card>
<StatusBox
title="Dormant users"
boxText={String(
stats?.users! - stats?.activeUsers?.last90!
)}
customChangeElement={
<Typography
component="span"
sx={{ color: dormantUsersColor }}
>
({dormantUsersPercentage.toFixed(1)}%)
</Typography>
}
>
{/* <HelpPopper id="dormant-users">
Sum of all configuration and state modifications in
the project.
</HelpPopper> */}
</StatusBox>
</Card>
<Card>
<StatusBox
title="Number of projects"
boxText={String(projects?.length)}
customChangeElement={<></>}
></StatusBox>
</Card>
<Card>
<StatusBox
title="Number of feature toggles"
boxText={String(stats?.featureToggles)}
customChangeElement={<></>}
></StatusBox>
</Card>
</CardsGrid>
<PageContent header={<PageHeader title="Health per project" />}>
<Table {...getTableProps()} rowHeight="standard">
<SortableTableHeader headerGroups={headerGroups} />
<TableBody {...getTableBodyProps()}>
{rows.map(row => {
prepareRow(row);
return (
<TableRow hover {...row.getRowProps()}>
{row.cells.map(cell => (
<TableCell {...cell.getCellProps()}>
{cell.render('Cell')}
</TableCell>
))}
</TableRow>
);
})}
</TableBody>
</Table>
</PageContent>
</>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,10 @@ import useSWR from 'swr';
import { useMemo } from 'react';
import { formatApiPath } from 'utils/formatPath';
import handleErrorResponses from '../httpErrorResponseHandler';

interface InstanceStats {
instanceId: string;
timestamp: Date;
versionOSS: string;
versionEnterprise?: string;
users: number;
featureToggles: number;
projects: number;
contextFields: number;
roles: number;
groups: number;
environments: number;
segments: number;
strategies: number;
featureExports: number;
featureImports: number;
SAMLenabled: boolean;
OIDCenabled: boolean;
}
import { InstanceAdminStatsSchema } from 'openapi';

export interface IInstanceStatsResponse {
stats?: InstanceStats;
stats?: InstanceAdminStatsSchema;
refetchGroup: () => void;
loading: boolean;
error?: Error;
Expand Down
1 change: 1 addition & 0 deletions frontend/src/interfaces/uiConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export interface IFlags {
integrationsRework?: boolean;
multipleRoles?: boolean;
doraMetrics?: boolean;
instanceHealthDashboard?: boolean;
[key: string]: boolean | Variant | undefined;
}

Expand Down
1 change: 1 addition & 0 deletions frontend/src/openapi/models/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ export * from './importTogglesSchema';
export * from './importTogglesValidateItemSchema';
export * from './importTogglesValidateSchema';
export * from './instanceAdminStatsSchema';
export * from './instanceAdminStatsSchemaActiveUsers';
export * from './instanceAdminStatsSchemaClientAppsItem';
export * from './instanceAdminStatsSchemaClientAppsItemRange';
export * from './invoicesSchema';
Expand Down
7 changes: 7 additions & 0 deletions frontend/src/openapi/models/instanceAdminStatsSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* Do not edit manually.
* See `gen:api` script in package.json
*/
import type { InstanceAdminStatsSchemaActiveUsers } from './instanceAdminStatsSchemaActiveUsers';
import type { InstanceAdminStatsSchemaClientAppsItem } from './instanceAdminStatsSchemaClientAppsItem';

/**
Expand All @@ -19,6 +20,8 @@ export interface InstanceAdminStatsSchema {
versionEnterprise?: string;
/** The number of users this instance has */
users?: number;
/** The number of active users in the last 7, 30 and 90 days */
activeUsers?: InstanceAdminStatsSchemaActiveUsers;
/** The number of feature-toggles this instance has */
featureToggles?: number;
/** The number of projects defined in this instance. */
Expand All @@ -41,6 +44,10 @@ export interface InstanceAdminStatsSchema {
OIDCenabled?: boolean;
/** A count of connected applications in the last week, last month and all time since last restart */
clientApps?: InstanceAdminStatsSchemaClientAppsItem[];
/** The number of export operations on this instance */
featureExports?: number;
/** The number of import operations on this instance */
featureImports?: number;
/** A SHA-256 checksum of the instance statistics to be used to verify that the data in this object has not been tampered with */
sum?: string;
}
17 changes: 17 additions & 0 deletions frontend/src/openapi/models/instanceAdminStatsSchemaActiveUsers.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/**
* Generated by Orval
* Do not edit manually.
* See `gen:api` script in package.json
*/

/**
* The number of active users in the last 7, 30 and 90 days
*/
export type InstanceAdminStatsSchemaActiveUsers = {
/** The number of active users in the last 7 days */
last7?: number;
/** The number of active users in the last 30 days */
last30?: number;
/** The number of active users in the last 90 days */
last90?: number;
};
Loading