fix: environment id missing bug (#4397)

Unleash · Aug 4, 2023 · d001b86 · d001b86
1 parent 8e3eaf1
commit d001b86
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyForm/FeatureStrategyForm.tsx b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyForm/FeatureStrategyForm.tsx
@@ -257,6 +257,8 @@ export const FeatureStrategyForm = ({
                     <StrategyVariants
                         strategy={strategy}
                         setStrategy={setStrategy}
+                        environment={environmentId}
+                        projectId={projectId}
                     />
                 }
             />

diff --git a/frontend/src/component/feature/StrategyTypes/StrategyVariants.test.tsx b/frontend/src/component/feature/StrategyTypes/StrategyVariants.test.tsx
@@ -32,7 +32,12 @@ test('should render variants', async () => {
         currentStrategy = strategy;
 
         return (
-            <StrategyVariants strategy={strategy} setStrategy={setStrategy} />
+            <StrategyVariants
+                strategy={strategy}
+                setStrategy={setStrategy}
+                projectId={'default'}
+                environment={'development'}
+            />
         );
     };
     render(

diff --git a/frontend/src/component/feature/StrategyTypes/StrategyVariants.tsx b/frontend/src/component/feature/StrategyTypes/StrategyVariants.tsx
@@ -24,9 +24,9 @@ export const StrategyVariants: FC<{
         React.SetStateAction<Partial<IFeatureStrategy>>
     >;
     strategy: Partial<IFeatureStrategy>;
-}> = ({ strategy, setStrategy }) => {
-    const projectId = useRequiredPathParam('projectId');
-    const environment = useRequiredQueryParam('environmentId');
+    projectId: string;
+    environment: string;
+}> = ({ strategy, setStrategy, projectId, environment }) => {
     const [variantsEdit, setVariantsEdit] = useState<IFeatureVariantEdit[]>([]);
     const theme = useTheme();
     const stickiness =