fix: remove extra call to features on project load (#5690)

Currently EnableEnvironmentDialog was loaded even if no feature was touched. Now it will only load, if feature toggle was selected.
Unleash · Dec 19, 2023 · c979e68 · c979e68
1 parent dce91b0
commit c979e68
Showing 1 changed file with 15 additions and 2 deletions.
diff --git a/...nent/project/Project/ProjectFeatureToggles/FeatureToggleSwitch/useFeatureToggleSwitch.tsx b/...nent/project/Project/ProjectFeatureToggles/FeatureToggleSwitch/useFeatureToggleSwitch.tsx
@@ -14,6 +14,7 @@ import {
     OnFeatureToggleSwitchArgs,
     UseFeatureToggleSwitchType,
 } from './FeatureToggleSwitch.types';
+import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
 
 type Middleware = (next: () => void) => void;
 
@@ -212,10 +213,19 @@ export const useFeatureToggleSwitch: UseFeatureToggleSwitchType = (
         [setProdGuardModalState],
     );
 
+    const featureSelected = enableEnvironmentDialogState.featureId.length !== 0;
+
     const modals = (
         <>
             <FeatureStrategyProdGuard {...prodGuardModalState} />
-            <EnableEnvironmentDialog {...enableEnvironmentDialogState} />
+            <ConditionallyRender
+                condition={featureSelected}
+                show={
+                    <EnableEnvironmentDialog
+                        {...enableEnvironmentDialogState}
+                    />
+                }
+            />
             <ChangeRequestDialogue
                 isOpen={changeRequestDialogDetails.isOpen}
                 onClose={() => {
@@ -238,5 +248,8 @@ export const useFeatureToggleSwitch: UseFeatureToggleSwitchType = (
         </>
     );
 
-    return { onToggle, modals };
+    return {
+        onToggle,
+        modals,
+    };
 };