feat: add service account tokens #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighphyre
commented
Aug 28, 2024
| ServiceAccountId types.Int64 `tfsdk:"service_account_id"` | ||
| Secret types.String `tfsdk:"secret"` | ||
| Description types.String `tfsdk:"description"` | ||
| ExpiresAt types.String `tfsdk:"expires_at"` |
There was a problem hiding this comment.
Notably I've excluded a few fields that I don't think make sense:
- LastSeen: doesn't seem to be useful for a terraform integration
- UserId: also doesn't seem to be useful for a terraform integration
This is really just to reduce public dependencies. These can be added later if they're needed but adding them now means making them sticky
gastonfournier
approved these changes
Aug 28, 2024
Comment on lines
+68
to
+70
| PlanModifiers: []planmodifier.Int64{ | ||
| int64planmodifier.RequiresReplace(), | ||
| }, |
There was a problem hiding this comment.
TIL "to mark the accessible properties as requiring a plan change. This means that any update to a service account token will trigger a delete and then recreate it from scratch"
Nice! I think this might be handy for #163 as well.
There was a problem hiding this comment.
Me too! Thank you ChatGPT cough
Oh cheers, might be valuable to be able to address that issue actually!
| }) | ||
| } | ||
|
|
||
| func TestAccServiceAccountTokenResourceUpdatingDescriptionGeneratesNewToken(t *testing.T) { |
sighphyre
force-pushed
the
feat/add-service-account-tokens
branch
from
a08f8ae to
b57c4bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds service account tokens to the service accounts. This one's a bit more hairy than the last because of sensitivity reasons and how we handle tokens on service accounts for a few reasons:
Because of these reasons, I've chosen to mark the accessible properties as requiring a plan change. This means that any update to a service account token will trigger a delete and then recreate it from scratch