Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use body::None instead of empty #2

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

phooijenga
Copy link
Contributor

Respond with an explicitly absent body instead of a zero-sized one to make it clear to other middleware (like actix_web::middleware::Compress) that it does not need further encoding.

See also unleash-edge#341.

Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. That's easier than my fix with a custom message body.

@chriswk chriswk merged commit c93f976 into Unleash:main Nov 23, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants