Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add the ability to open wikis in the browser #77

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

Epicpkmn11
Copy link
Member

@Epicpkmn11 Epicpkmn11 commented Mar 23, 2021

Currently press SELECT and if the app has one it'll quit UU and open the browser
I feel like it should be possible to launch the browser without quitting UU as you can launch it from the home menu while the app is running, but that wasn't working.

  • Add an icon you can touch, probably by release notes is my first though, I'll try find a good one in the morning
  • Maybe make SELECT not open it? I just did that for testing but it might be an alright key for it I guess
  • Add a warning that this will quit UU unless we can figure out how to not quit UU
  • Try fix it quitting UU
  • Try fix the browser sometimes being unresponsive (might be fixed?)
  • New problem: Fix being frozen on return from browser
  • Fix missing last character on o3DS

@SuperSaiyajinStackZ
Copy link
Member

I also added the ability for custom Themes in the latest commit through a Themes.json. Might want to change the Pull Request Description or so. ;P

@Epicpkmn11
Copy link
Member Author

I also added the ability for custom Themes in the latest commit through a Themes.json. Might want to change the Pull Request Description or so. ;P

Should just not put unrelated things into specific branches ;P

I think it'd be better to cherry-pick that commit over to master and just wait on this for the next release since it's being buggy but do the rest now since there's already several bug fixes worth doing a release for

Currently press SELECT and if the app has one it'll *quit UU* and open the browser
I feel like it should be possible to launch the browser without quitting UU as you can launch it from the home menu while the app is running, but that wasn't working.
NOTE: This now freezes on returning to UU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants