Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-1631: FramingTransposer with a dead zone would sometimes drift #1031

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Dec 19, 2024

Purpose of this PR

CMCL-1631: FramingTransposer camera drift when nonzero dead zone.
Fix was to improve precision of calculation.

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.21%. Comparing base (ba4cc2b) to head (323516c).
Report is 76 commits behind head on main.

Files with missing lines Patch % Lines
...Runtime/Deprecated/CinemachineFramingTransposer.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
+ Coverage   26.97%   27.21%   +0.24%     
==========================================
  Files         254      254              
  Lines       28418    28485      +67     
==========================================
+ Hits         7665     7753      +88     
+ Misses      20753    20732      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glabute glabute requested a review from alexzaranek January 7, 2025 15:15
Copy link

@alexzaranek alexzaranek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes and the drift is gone 👍

@glabute glabute merged commit 0cb1aa8 into main Jan 8, 2025
69 checks passed
@glabute glabute deleted the dev/framing-transposer-dead-zone-drift branch January 8, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants