Drop support for Python 3.8 #28
Conversation
Argus itself does not support 3.8 anymore
johannaengland
requested review from
lunkwill42,
hmpf,
stveit and
podliashanyk
|
Test results 5 files 5 suites 2s ⏱️ Results for commit 23b2524. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Argus itself does not support 3.8 anymore.
IMO, this is by itself not a valid reason to drop 3.8 support in pyargus. Which versions of Python Argus runs on is irrelevant to pyargus.
However, once it becomes an uphill battle to keep support for 3.8 in pyargus, we can drop it. I believe you used the same reasoning for dropping 3.7 in #12, but that was also premature (but then, GitHub Actions ubuntu-latest image made testing on 3.7 difficult just a few months later, and it was time)
There was a problem hiding this comment.
To make working on #20 easier.
Well, see, a reference to jog my post-xmas-memory. Much better 😆
To make working on #20 easier.