-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing form inputs in RoomFilterForm and NetboxTypeFilterForm in seeddb #3178
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
This make filter fields render correctly
2fc9fe3
to
fd88b5c
Compare
Test results 9 files 9 suites 8m 47s ⏱️ Results for commit 111e075. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3178 +/- ##
==========================================
- Coverage 60.40% 60.39% -0.01%
==========================================
Files 605 605
Lines 43710 43703 -7
Branches 48 48
==========================================
- Hits 26401 26394 -7
Misses 17297 17297
Partials 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! No idea how this slipped my notice while working on #3126.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But actually thinking about the general principle of the function get_single_layout
- if we give the opportunity of actually having a list as parameter, that defeats the purpose of it being for a single filter - we will either have to change the docstring and possibly even name of the function or go only allow one field as input
Sorry for the back and forth in reviews 😅 |
No problem! 😌 |
Co-authored-by: Johanna England <[email protected]>
Quality Gate passedIssues Measures |
To fix general bug that was introduced in #3126.
http://localhost/seeddb/type/
http://localhost/seeddb/room/
UI Before fix: