Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing form inputs in RoomFilterForm and NetboxTypeFilterForm in seeddb #3178

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

podliashanyk
Copy link
Contributor

@podliashanyk podliashanyk commented Nov 8, 2024

To fix general bug that was introduced in #3126.

http://localhost/seeddb/type/
http://localhost/seeddb/room/

UI Before fix:

Screenshot 2024-11-08 at 16 42 41

Screenshot 2024-11-08 at 16 42 53

@podliashanyk podliashanyk requested a review from a team November 8, 2024 15:44
@podliashanyk podliashanyk self-assigned this Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.26s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@podliashanyk podliashanyk force-pushed the fix-missing-filter-inputs-in-seeddb branch from 2fc9fe3 to fd88b5c Compare November 8, 2024 15:46
Copy link

github-actions bot commented Nov 8, 2024

Test results

    9 files      9 suites   8m 47s ⏱️
2 138 tests 2 138 ✅ 0 💤 0 ❌
4 015 runs  4 015 ✅ 0 💤 0 ❌

Results for commit 111e075.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (b8fec64) to head (111e075).
Report is 64 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3178      +/-   ##
==========================================
- Coverage   60.40%   60.39%   -0.01%     
==========================================
  Files         605      605              
  Lines       43710    43703       -7     
  Branches       48       48              
==========================================
- Hits        26401    26394       -7     
  Misses      17297    17297              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! No idea how this slipped my notice while working on #3126.

Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But actually thinking about the general principle of the function get_single_layout - if we give the opportunity of actually having a list as parameter, that defeats the purpose of it being for a single filter - we will either have to change the docstring and possibly even name of the function or go only allow one field as input

@johannaengland
Copy link
Contributor

Sorry for the back and forth in reviews 😅

@podliashanyk
Copy link
Contributor Author

Good catch! No idea how this slipped my notice while working on #3126.

It also slipped through mine and @stveit notice as well since we both approved that PR. A collective lapse in criticism 😄

@podliashanyk
Copy link
Contributor Author

Sorry for the back and forth in reviews 😅

No problem! 😌

@podliashanyk podliashanyk merged commit 901433d into master Nov 15, 2024
12 of 14 checks passed
@podliashanyk podliashanyk deleted the fix-missing-filter-inputs-in-seeddb branch November 15, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants