Switch DeviceGroupForm in seeddb to new uncrispy way
#3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannaengland
requested review from
lunkwill42,
hmpf,
stveit and
podliashanyk
johannaengland
changed the title
DeviceGroupForm in seeddb to new uncrispy way
johannaengland
force-pushed
the
refactor/switch-seeddb-to-new-uncrispy-way
branch
from
55c3cf2
to
83a634b
Compare
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 22s ⏱️ Results for commit 8339f1e. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3122 +/- ##
=======================================
Coverage 60.44% 60.44%
=======================================
Files 605 605
Lines 43761 43762 +1
Branches 48 48
=======================================
+ Hits 26451 26452 +1
Misses 17298 17298
Partials 12 12 ☔ View full report in Codecov by Sentry. |
stveit
requested changes
Oct 10, 2024
stveit
approved these changes
Oct 10, 2024
This removes our old idea of adding templates and uses the new way that reimplemented crispy fields
johannaengland
force-pushed
the
refactor/switch-seeddb-to-new-uncrispy-way
branch
from
cce0dee
to
8339f1e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes again most changes done in #2994 and instead uses our newest way of uncrispifying forms.
Urls:
http://localhost/seeddb/netboxgroup/add/
http://localhost/seeddb/netboxgroup/edit/<id>