Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncrispify service forms in seedDB #3103

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Oct 8, 2024

Closes #3102.

Urls:
http://localhost/seeddb/service/add/ (here one needs to click around a bit, it's a multiple step form)
http://localhost/seeddb/service/edit/<id>

Copy link

sonarqubecloud bot commented Oct 8, 2024

Copy link

github-actions bot commented Oct 8, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.47s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Oct 8, 2024

Test results

    9 files      9 suites   8m 22s ⏱️
2 136 tests 2 136 ✅ 0 💤 0 ❌
4 011 runs  4 011 ✅ 0 💤 0 ❌

Results for commit 76205e5.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.45%. Comparing base (fb52d6a) to head (76205e5).
Report is 294 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3103   +/-   ##
=======================================
  Coverage   60.44%   60.45%           
=======================================
  Files         605      605           
  Lines       43773    43768    -5     
  Branches       48       48           
=======================================
- Hits        26459    26458    -1     
+ Misses      17302    17298    -4     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@johannaengland johannaengland merged commit f279463 into master Oct 10, 2024
13 of 14 checks passed
@johannaengland johannaengland deleted the refactor/uncrispify-service-forms branch October 10, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispify service forms in seedDB
2 participants