Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncrispify SearchForm in ipdevinfo #3098

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

johannaengland
Copy link
Contributor

Closes #3096.

Copy link

github-actions bot commented Oct 7, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.42s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Oct 7, 2024

Test results

    9 files      9 suites   8m 9s ⏱️
2 136 tests 2 136 ✅ 0 💤 0 ❌
4 011 runs  4 011 ✅ 0 💤 0 ❌

Results for commit a81ad09.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.44%. Comparing base (1f657b1) to head (a81ad09).
Report is 296 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3098      +/-   ##
==========================================
- Coverage   60.44%   60.44%   -0.01%     
==========================================
  Files         605      605              
  Lines       43779    43777       -2     
  Branches       48       48              
==========================================
- Hits        26461    26459       -2     
  Misses      17306    17306              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a small cleanup that remains

python/nav/web/ipdevinfo/forms.py Show resolved Hide resolved
@johannaengland johannaengland force-pushed the refactor/uncrispify-search-form-ipdevinfo branch from cbb70d9 to a81ad09 Compare October 8, 2024 09:14
Copy link

sonarqubecloud bot commented Oct 8, 2024

@johannaengland johannaengland merged commit b3aba5e into master Oct 8, 2024
13 of 14 checks passed
@johannaengland johannaengland deleted the refactor/uncrispify-search-form-ipdevinfo branch October 8, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispify SearchForm in ipdevinfo
2 participants