Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renderer template tag for noncrispy field #3097

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

podliashanyk
Copy link
Contributor

Closes #3074

@podliashanyk podliashanyk requested a review from a team October 7, 2024 12:44
@podliashanyk podliashanyk self-assigned this Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.43s
✅ PYTHON ruff 987 0 0.08s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Oct 7, 2024

Test results

    9 files      9 suites   8m 12s ⏱️
2 136 tests 2 136 ✅ 0 💤 0 ❌
4 011 runs  4 011 ✅ 0 💤 0 ❌

Results for commit af3b7cd.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.44%. Comparing base (2899bea) to head (af3b7cd).
Report is 307 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3097      +/-   ##
==========================================
- Coverage   60.45%   60.44%   -0.02%     
==========================================
  Files         605      605              
  Lines       43797    43779      -18     
  Branches       48       48              
==========================================
- Hits        26479    26461      -18     
  Misses      17306    17306              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes things much nicer!

The only small comment that I have is that I don't like naming the tag field, I would prefer keeping it show_field or something similar, because reading {% field field %} is a bit confusing

For better readability
@podliashanyk
Copy link
Contributor Author

This makes things much nicer!

The only small comment that I have is that I don't like naming the tag field, I would prefer keeping it show_field or something similar, because reading {% field field %} is a bit confusing

Renamed to show_field

Copy link

sonarqubecloud bot commented Oct 8, 2024

@podliashanyk podliashanyk merged commit 1f657b1 into master Oct 8, 2024
12 of 14 checks passed
@podliashanyk podliashanyk deleted the add-template-tag-for-noncrispy-field branch October 8, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add our own field renderer tag for non-crispy forms
2 participants