-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add renderer template tag for noncrispy field #3097
Conversation
Follows the pattern described in Django docs: https://docs.djangoproject.com/en/5.1/howto/custom-template-tags/#inclusion-tags
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 9 files 9 suites 8m 12s ⏱️ Results for commit af3b7cd. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3097 +/- ##
==========================================
- Coverage 60.45% 60.44% -0.02%
==========================================
Files 605 605
Lines 43797 43779 -18
Branches 48 48
==========================================
- Hits 26479 26461 -18
Misses 17306 17306
Partials 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes things much nicer!
The only small comment that I have is that I don't like naming the tag field
, I would prefer keeping it show_field
or something similar, because reading {% field field %}
is a bit confusing
For better readability
Renamed to |
Quality Gate passedIssues Measures |
Closes #3074