-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncrispify AlertAddressForm #3080
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 9 files 9 suites 8m 30s ⏱️ Results for commit 2d5d249. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3080 +/- ##
==========================================
- Coverage 60.46% 60.45% -0.01%
==========================================
Files 605 605
Lines 43801 43793 -8
Branches 48 48
==========================================
- Hits 26483 26475 -8
Misses 17306 17306
Partials 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When comparing the resulting HTML when editing an alert address there is one field missing after the changes where applied:
<input type="hidden" name="id" value="1034" id="id_id">
I am not sure why a hidden field is not being rendered
Quality Gate passedIssues Measures |
I could not reproduce, it seems to be there for me when I'm testing. But I did see that I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the id
field is there!
Fixes #3076
I assume that the column containing
HTML('')
was there to act as a fake column so the formatting of the other columns was correct. If this is removed, then one of the columns get sent far to the right.A
FormColumn
with an emptyfields
argument seems to accomplish the exact same thing.URL: http://localhost/alertprofiles/address/