-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncrispify ActivityIntervalForm
in ipdevinfo
#3078
Uncrispify ActivityIntervalForm
in ipdevinfo
#3078
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 9 files 9 suites 8m 32s ⏱️ Results for commit 1f05e1f. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3078 +/- ##
=======================================
Coverage 60.41% 60.41%
=======================================
Files 605 605
Lines 43733 43729 -4
Branches 48 48
=======================================
- Hits 26422 26420 -2
+ Misses 17299 17297 -2
Partials 12 12 ☔ View full report in Codecov by Sentry. |
3482fe0
to
0abf30e
Compare
2093397
to
a786816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only issue I found is that there is now an extra whitespace, so the "Recheck activity" button is slightly further to the right.
Also found a bug that is present on master as well (so not caused by this PR): if you put in a number that is too large it gives you a 500 error (OverflowError
)
Then please add an issue for that! |
I have absolutely no idea where this extra whitespace is coming from. @podliashanyk, maybe you have any idea why this suddenly appeared? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works!
Wrapping the whole content of the python/nav/web/templates/custom_crispy_templates/submit_field.html
with {% spaceless %}...{% endspaceless %}
will fix the issue. But it is a minor difference IMO so I have nothing against if we merge as is :)
94c6a92
to
a786816
Compare
a786816
to
1f05e1f
Compare
Quality Gate passedIssues Measures |
Closes #3060.
Url: ipdevinfo/<netbox_sysname>/modules/<perspective> (where perspective is
swportstatus
,swportactive
, orgwportstatus