Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncrispify ActivityIntervalForm in ipdevinfo #3078

Merged

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Oct 3, 2024

Closes #3060.

Url: ipdevinfo/<netbox_sysname>/modules/<perspective> (where perspective is swportstatus, swportactive, or gwportstatus

Copy link

github-actions bot commented Oct 3, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 10.93s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Oct 3, 2024

Test results

    9 files      9 suites   8m 32s ⏱️
2 135 tests 2 135 ✅ 0 💤 0 ❌
4 009 runs  4 009 ✅ 0 💤 0 ❌

Results for commit 1f05e1f.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.41%. Comparing base (37c2b88) to head (1f05e1f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3078   +/-   ##
=======================================
  Coverage   60.41%   60.41%           
=======================================
  Files         605      605           
  Lines       43733    43729    -4     
  Branches       48       48           
=======================================
- Hits        26422    26420    -2     
+ Misses      17299    17297    -2     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland self-assigned this Oct 3, 2024
@johannaengland johannaengland marked this pull request as ready for review October 3, 2024 15:28
@johannaengland johannaengland force-pushed the refactor/uncrispify-activity-interval-form-ipdevinfo branch from 3482fe0 to 0abf30e Compare October 3, 2024 15:31
@johannaengland johannaengland force-pushed the refactor/uncrispify-activity-interval-form-ipdevinfo branch 2 times, most recently from 2093397 to a786816 Compare October 11, 2024 06:58
Copy link
Contributor

@stveit stveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only issue I found is that there is now an extra whitespace, so the "Recheck activity" button is slightly further to the right.

Master:
image

This PR:
image

Also found a bug that is present on master as well (so not caused by this PR): if you put in a number that is too large it gives you a 500 error (OverflowError)

@johannaengland
Copy link
Contributor Author

Also found a bug that is present on master as well (so not caused by this PR): if you put in a number that is too large it gives you a 500 error (OverflowError)

Then please add an issue for that!

@johannaengland
Copy link
Contributor Author

Only issue I found is that there is now an extra whitespace, so the "Recheck activity" button is slightly further to the right.

Master: image

This PR: image

I have absolutely no idea where this extra whitespace is coming from. @podliashanyk, maybe you have any idea why this suddenly appeared?

@johannaengland johannaengland requested a review from stveit November 4, 2024 10:23
Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!
Wrapping the whole content of the python/nav/web/templates/custom_crispy_templates/submit_field.html with {% spaceless %}...{% endspaceless %} will fix the issue. But it is a minor difference IMO so I have nothing against if we merge as is :)

@podliashanyk podliashanyk force-pushed the refactor/uncrispify-activity-interval-form-ipdevinfo branch from 94c6a92 to a786816 Compare November 6, 2024 14:39
@johannaengland johannaengland force-pushed the refactor/uncrispify-activity-interval-form-ipdevinfo branch from a786816 to 1f05e1f Compare November 7, 2024 13:00
Copy link

sonarqubecloud bot commented Nov 7, 2024

@johannaengland johannaengland merged commit f74ddf0 into master Nov 7, 2024
13 of 14 checks passed
@johannaengland johannaengland deleted the refactor/uncrispify-activity-interval-form-ipdevinfo branch November 7, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispify ActivityIntervalForm in ipdevinfo
3 participants