Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spaceless wrapper around helpfield template #3073

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Oct 3, 2024

Whitespace showed up on checkboxes without this.

Diff is large cause of indentation changes

Whitespace showed up on checkboxes without this
@stveit stveit self-assigned this Oct 3, 2024
Copy link

sonarcloud bot commented Oct 3, 2024

Copy link

github-actions bot commented Oct 3, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.16s
✅ PYTHON ruff 987 0 0.09s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@stveit stveit mentioned this pull request Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Test results

    9 files      9 suites   8m 4s ⏱️
2 136 tests 2 136 ✅ 0 💤 0 ❌
4 011 runs  4 011 ✅ 0 💤 0 ❌

Results for commit 358a355.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.48%. Comparing base (63d4fd3) to head (358a355).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3073   +/-   ##
=======================================
  Coverage   60.47%   60.48%           
=======================================
  Files         605      605           
  Lines       43820    43821    +1     
  Branches       48       48           
=======================================
+ Hits        26502    26503    +1     
  Misses      17306    17306           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our field_helptext_as_icon.html is supposed to be a customization of crispy-foundation field.html. Upon further inspection of crispy field template I see that they only wrap contents of div with spaceless. Yet our field_helptext_as_icon.html never had spaceless and it worked before. Crispy foundation wraps whole form content in spaceless. I suggest we keep placement of spaceless in helpfield as suggested in this PR (and deviate from how it is placed in crispy field template). Additionally in a separate PR we can wrap the content of _form_content.html with spaceless to match the crispy form content.

@stveit stveit merged commit c78c57d into master Oct 3, 2024
12 of 14 checks passed
@stveit stveit deleted the uncrispify/add-spaceless-around-help-field-template branch October 3, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants