Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncrispify AlertSubscriptionForm #3058

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Oct 1, 2024

@stveit stveit self-assigned this Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.25s
✅ PYTHON ruff 987 0 0.09s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Oct 1, 2024

Test results

    9 files      9 suites   8m 16s ⏱️
2 136 tests 2 136 ✅ 0 💤 0 ❌
4 011 runs  4 011 ✅ 0 💤 0 ❌

Results for commit 174f143.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (a7246a2) to head (174f143).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3058      +/-   ##
==========================================
- Coverage   60.47%   60.47%   -0.01%     
==========================================
  Files         605      605              
  Lines       43823    43824       +1     
  Branches       48       48              
==========================================
  Hits        26504    26504              
- Misses      17307    17308       +1     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stveit stveit force-pushed the uncrispify/AlertSubscriptionForm branch 2 times, most recently from e896513 to ef13196 Compare October 1, 2024 16:37
@stveit
Copy link
Contributor Author

stveit commented Oct 1, 2024

Reliant on #3066

@stveit stveit added the blocked label Oct 1, 2024
@podliashanyk
Copy link
Contributor

Also reliant on #3059 since this form might have non_field_errors upon validation

@stveit stveit removed the blocked label Oct 2, 2024
@stveit stveit force-pushed the uncrispify/AlertSubscriptionForm branch from ef13196 to 174f143 Compare October 2, 2024 09:39
Copy link

sonarcloud bot commented Oct 2, 2024

@stveit stveit marked this pull request as ready for review October 2, 2024 09:44
@johannaengland johannaengland requested a review from a team October 2, 2024 10:50
@stveit stveit merged commit 63d4fd3 into master Oct 2, 2024
13 of 14 checks passed
@stveit stveit deleted the uncrispify/AlertSubscriptionForm branch October 2, 2024 12:31
Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@stveit stveit mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispyfy nav.web.alertprofiles.forms.AlertSubscriptionForm
3 participants