-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncrispify ThresholdForm #3052
Uncrispify ThresholdForm #3052
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
60c91c5
to
0a7ee93
Compare
Test results 9 files 9 suites 8m 34s ⏱️ Results for commit 6c651d8. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3052 +/- ##
=======================================
Coverage 60.47% 60.48%
=======================================
Files 605 605
Lines 43823 43819 -4
Branches 48 48
=======================================
- Hits 26504 26502 -2
+ Misses 17307 17305 -2
Partials 12 12 ☔ View full report in Codecov by Sentry. |
7b5e56f
to
dfdfd39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! All the essentials from the original form are preserved except the field errors for HelpField
. See #3066
dfdfd39
to
6c651d8
Compare
Quality Gate passedIssues Measures |
Fixes #3050
url:
http://localhost/threshold/ Adding a new rule and editing existing rules are controlled by this form