Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncrispify ThresholdForm #3052

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Uncrispify ThresholdForm #3052

merged 2 commits into from
Oct 2, 2024

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Sep 30, 2024

Fixes #3050

url:
http://localhost/threshold/ Adding a new rule and editing existing rules are controlled by this form

@stveit stveit self-assigned this Sep 30, 2024
Copy link

github-actions bot commented Sep 30, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.15s
✅ PYTHON ruff 987 0 0.09s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@stveit stveit force-pushed the uncrispify/ThresholdForm branch 3 times, most recently from 60c91c5 to 0a7ee93 Compare September 30, 2024 12:14
Copy link

github-actions bot commented Sep 30, 2024

Test results

    9 files      9 suites   8m 34s ⏱️
2 136 tests 2 136 ✅ 0 💤 0 ❌
4 011 runs  4 011 ✅ 0 💤 0 ❌

Results for commit 6c651d8.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.48%. Comparing base (a7246a2) to head (6c651d8).
Report is 366 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3052   +/-   ##
=======================================
  Coverage   60.47%   60.48%           
=======================================
  Files         605      605           
  Lines       43823    43819    -4     
  Branches       48       48           
=======================================
- Hits        26504    26502    -2     
+ Misses      17307    17305    -2     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stveit stveit force-pushed the uncrispify/ThresholdForm branch 2 times, most recently from 7b5e56f to dfdfd39 Compare October 1, 2024 08:04
@stveit stveit changed the base branch from master to uncrispify/add-noncrispy-help-form-field October 1, 2024 08:05
Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! All the essentials from the original form are preserved except the field errors for HelpField. See #3066

@stveit stveit changed the base branch from uncrispify/add-noncrispy-help-form-field to master October 1, 2024 16:34
@stveit stveit force-pushed the uncrispify/ThresholdForm branch from dfdfd39 to 6c651d8 Compare October 2, 2024 09:39
@stveit stveit removed the blocked label Oct 2, 2024
Copy link

sonarqubecloud bot commented Oct 2, 2024

@stveit stveit merged commit 48aeae6 into master Oct 2, 2024
13 of 14 checks passed
@stveit stveit deleted the uncrispify/ThresholdForm branch October 2, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispyfy nav.web.threshold.forms.ThresholdForm
2 participants