Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ambiguous variable names #3043

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

johannaengland
Copy link
Contributor

Another step in preparation of adding more ruff rules. This is for E741 - Ambiguous variable name

Copy link

Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.18s
✅ PYTHON ruff 987 0 0.08s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

Test results

    9 files      9 suites   8m 27s ⏱️
2 128 tests 2 128 ✅ 0 💤 0 ❌
3 995 runs  3 995 ✅ 0 💤 0 ❌

Results for commit ee956e9.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (5d6feef) to head (ee956e9).
Report is 429 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3043   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files         605      605           
  Lines       43816    43816           
  Branches       48       48           
=======================================
  Hits        26497    26497           
  Misses      17307    17307           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland merged commit e73fd26 into master Sep 27, 2024
13 of 14 checks passed
@johannaengland johannaengland deleted the cleanup/rename-ambiguous-variable-names branch September 27, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants