Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncrispyfy JustificationForm in arnold #3039

Merged

Conversation

podliashanyk
Copy link
Contributor

@podliashanyk podliashanyk commented Sep 26, 2024

Closes #3032

Depends on #3034, #3048

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.46%. Comparing base (2dae9d3) to head (99151dd).
Report is 389 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3039      +/-   ##
==========================================
+ Coverage   60.44%   60.46%   +0.01%     
==========================================
  Files         605      605              
  Lines       43828    43826       -2     
  Branches       48       48              
==========================================
+ Hits        26494    26501       +7     
+ Misses      17322    17313       -9     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@podliashanyk podliashanyk force-pushed the uncrispyfy-arnold-justification-form branch 2 times, most recently from 35c3d66 to 64c7d0c Compare September 27, 2024 11:46
@podliashanyk podliashanyk marked this pull request as ready for review September 27, 2024 11:47
@podliashanyk podliashanyk requested a review from a team September 27, 2024 11:47
@podliashanyk podliashanyk marked this pull request as draft September 27, 2024 13:13
@podliashanyk podliashanyk force-pushed the uncrispyfy-arnold-justification-form branch from 64c7d0c to 04ff486 Compare September 30, 2024 09:59
@podliashanyk podliashanyk force-pushed the uncrispyfy-arnold-justification-form branch from 04ff486 to 3a0f0c0 Compare September 30, 2024 10:00
@podliashanyk podliashanyk marked this pull request as ready for review September 30, 2024 10:03
Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure what we have concluded about CSRF-tokens, because that one is missing when comparing the before and after

python/nav/web/templates/arnold/justifications.html Outdated Show resolved Hide resolved
Copy link

@podliashanyk
Copy link
Contributor Author

I am unsure what we have concluded about CSRF-tokens, because that one is missing when comparing the before and after

Created a separate issue for that #3055

@podliashanyk podliashanyk merged commit 9eeeb3c into Uninett:master Oct 1, 2024
12 of 13 checks passed
@podliashanyk podliashanyk deleted the uncrispyfy-arnold-justification-form branch October 1, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispyfy nav.web.arnold.forms.JustificationForm
2 participants