Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HTML validation warnings as failures #3007

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lunkwill42
Copy link
Member

Most problems that tidy detects appears to be classed as warnings, not errors, as HTML5 validation rules can be quite lax.

This turns on warnings in our validation results just to see how many we actually get.

@lunkwill42 lunkwill42 self-assigned this Sep 23, 2024
Copy link

github-actions bot commented Sep 23, 2024

Test results

    7 files      7 suites   3m 52s ⏱️
2 107 tests 2 106 ✅ 0 💤 1 ❌
2 923 runs  2 922 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 973528f.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (test/webcrawler-as-single-test@809a18a). Learn more about missing BASE report.

Additional details and impacted files
@@                        Coverage Diff                        @@
##             test/webcrawler-as-single-test    #3007   +/-   ##
=================================================================
  Coverage                                  ?   56.68%           
=================================================================
  Files                                     ?      602           
  Lines                                     ?    43713           
  Branches                                  ?       48           
=================================================================
  Hits                                      ?    24778           
  Misses                                    ?    18923           
  Partials                                  ?       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 23, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 987 0 23.89s
✅ PYTHON flake8 987 0 433.47s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@lunkwill42 lunkwill42 force-pushed the test/enable-html-warnings-during-validation branch from e086522 to 8fd8a4a Compare September 24, 2024 10:23
Most problems that tidy detects appears to be classed as warnings, not
errors, as HTML5 validation rules can be quite lax.

This turns on warnings in our validation results just to see how many
we actually get.
@lunkwill42 lunkwill42 force-pushed the test/enable-html-warnings-during-validation branch from 8fd8a4a to 973528f Compare September 24, 2024 10:32
Base automatically changed from test/webcrawler-as-single-test to master September 24, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant