Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crispy-forms from AlertProfilesForm in alert profiles #3001

Merged

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Sep 20, 2024

Closes #2999.

Url: /alertprofiles/profile/<profile-id>/

@johannaengland johannaengland marked this pull request as ready for review October 3, 2024 15:48
Copy link

sonarcloud bot commented Oct 3, 2024

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.46%. Comparing base (b507e20) to head (af68b0c).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3001      +/-   ##
==========================================
- Coverage   60.46%   60.46%   -0.01%     
==========================================
  Files         605      605              
  Lines       43801    43800       -1     
  Branches       48       48              
==========================================
- Hits        26483    26482       -1     
  Misses      17306    17306              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stveit stveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work just fine 👍

@johannaengland johannaengland merged commit faef7aa into Uninett:master Oct 4, 2024
12 of 13 checks passed
@johannaengland johannaengland deleted the refactor/alert-profiles-form branch October 4, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispify AlertProfileForm in alert profiles
2 participants