Uncrispyfy foundation5 field

[podliashanyk]

Introduces a reusable field template for #2794 (see 550de56).

Found templates/foundation-5/field.html hidden gem, which is implicitly (and explicitly) used in forms across the app.
This PR as-is fixes:

• most of Uncrispyfy all edit- and add-forms in /sedddb #2996 (see updated list there)
• yet undiscovered usages of form fields, aka those not mentioned in Get rid of crispy-forms #2794 because of implicit use of field template
• reduces the need to copy-paste html when uncrispyfying forms already mentioned in Get rid of crispy-forms #2794

Best reviewed: commit-for-commit.

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	988		0	23.18s
✅ PYTHON	flake8	988		0	427.8s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

[github-actions]

Test results

    9 files      9 suites   8m 31s ⏱️
3 333 tests 3 333 ✅ 0 💤 0 ❌
6 405 runs  6 405 ✅ 0 💤 0 ❌

Results for commit e07a0a0.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.76%. Comparing base (46c253f) to head (e07a0a0).
Report is 102 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3000      +/-   ##
==========================================
+ Coverage   56.60%   56.76%   +0.16%     
==========================================
  Files         602      603       +1     
  Lines       43722    43720       -2     
  Branches       48       48              
==========================================
+ Hits        24747    24816      +69     
+ Misses      18963    18892      -71     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lunkwill42]

Just an initial comment before I actually review: Yes, crispy-forms-foundation is mostly based on regular Django templates. NAV is currently (in principle) locked to crispy-forms-foundation==0.7.1, whose base templates can be found here: https://github.com/sveetch/crispy-forms-foundation/tree/0.7.1/crispy_forms_foundation/templates/foundation-5

You've discovered some of NAV's own overrides to those templates :)

[lunkwill42]

This looks good to me. Essentially, we would just be re-implementing our own custom subset of crispy-forms if we go down this route, and that might be good enough.

The important part of it is that we shouldn't have to write complete form templates over and over, when crispy-forms is essentially just about re-using the same template over and over.

[lunkwill42]

This is so trivial that I wouldn't bother with citing a source...