Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove space in div class name in filter form #2992

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Sep 19, 2024

A little fix to #2981 that I found while comparing the html of old and new filter forms.
Before it was <div id="div_id_net_type" class="ctrlHolder "> and now it is <div id="div_id_net_type" class="ctrlHolder">

Not sure if it actually makes a difference?

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.58%. Comparing base (c5dfce2) to head (aa0a8cb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2992   +/-   ##
=======================================
  Coverage   56.58%   56.58%           
=======================================
  Files         602      602           
  Lines       43729    43729           
  Branches       48       48           
=======================================
  Hits        24744    24744           
  Misses      18973    18973           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't make a lick of difference to an HTML parser, but it looks tidier for humans this way :)

@johannaengland johannaengland merged commit 8d039e0 into Uninett:master Sep 19, 2024
11 of 12 checks passed
@johannaengland johannaengland deleted the refactor/fix-space-in-filter-form branch September 19, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants