Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crispy-forms from NetboxTypeFilterForm #2987

Merged

Conversation

lunkwill42
Copy link
Member

Using pattern established by the RoomFilterForm refactor

Closes #2986

Using pattern established by the `RoomFilterForm` refactor
@lunkwill42 lunkwill42 self-assigned this Sep 18, 2024
@lunkwill42 lunkwill42 requested a review from a team September 18, 2024 13:49
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.31%. Comparing base (807deb4) to head (30127d6).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2987   +/-   ##
=======================================
  Coverage   56.30%   56.31%           
=======================================
  Files         602      602           
  Lines       43728    43725    -3     
  Branches       48       48           
=======================================
  Hits        24622    24622           
+ Misses      19094    19091    -3     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lunkwill42 lunkwill42 merged commit 393645d into Uninett:master Sep 20, 2024
10 of 11 checks passed
@lunkwill42 lunkwill42 deleted the refactor/netbox-type-filter-form branch September 20, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispyfy nav.web.seeddb.forms.NetboxTypeFilterForm
4 participants