Fix seeddb netbox-edit form so that empty function field will remove function info from netbox #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2952 +/- ##
==========================================
+ Coverage 56.35% 56.46% +0.10%
==========================================
Files 603 601 -2
Lines 43849 43816 -33
Branches 48 48
==========================================
+ Hits 24713 24741 +28
+ Misses 19124 19063 -61
Partials 12 12 ☔ View full report in Codecov by Sentry. |
jorund1
force-pushed
the
seeddb-empty-netbox-function-field-fix-aug-19
branch
4 times, most recently
from
a14ca71
to
6241213
Compare
…function info from netbox
jorund1
force-pushed
the
seeddb-empty-netbox-function-field-fix-aug-19
branch
from
6241213
to
b843585
Compare
lunkwill42
reviewed
Aug 23, 2024
There was a problem hiding this comment.
Nice work, @jorund1 :) Please don't forget to sign the updated CLA.
Co-authored-by: Morten Brekkevold <[email protected]>
lunkwill42
reviewed
Aug 23, 2024
My bad, fixed now! |
johannaengland
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2269