Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from super linter to mega linter #2941

Merged

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Jul 3, 2024

More info to the configuration of MegaLinter can be found here: https://megalinter.io/latest/configuration/
For example that DEFAULT_BRANCH has been deprecated.

I noticed that flake8 was still throwing errors, possibly because it has never been run on the full codebase, only on changes, so I added two #noqa and added one template file to the files that are ignored by flake8.

After approval I will set VALIDATE_ALL_CODEBASE to only do a full run on pushes to master, otherwise just linting the difference.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.37%. Comparing base (2d9827d) to head (371fa36).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2941   +/-   ##
=======================================
  Coverage   56.37%   56.37%           
=======================================
  Files         602      602           
  Lines       43813    43813           
  Branches       48       48           
=======================================
  Hits        24700    24700           
  Misses      19101    19101           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland force-pushed the workflows/switch-to-megalinter branch 3 times, most recently from e54cac6 to 9250f7c Compare July 4, 2024 08:06
@johannaengland johannaengland force-pushed the workflows/switch-to-megalinter branch 6 times, most recently from ce90141 to e494181 Compare August 27, 2024 12:54
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. I'm not sure why we have flake8 config in tox.ini and black in pyproject.toml. Flake8 should really be moved to pyproject.toml also, but since you're attempting to replace it with ruff, I'd wait for that instead :)

@johannaengland
Copy link
Contributor Author

Looks ok to me. I'm not sure why we have flake8 config in tox.ini and black in pyproject.toml. Flake8 should really be moved to pyproject.toml also, but since you're attempting to replace it with ruff, I'd wait for that instead :)

Flake8 does not support pyproject.toml, but since I am removing flake8 anyway in #2961 we don't have to worry about it

@johannaengland johannaengland merged commit 1652d80 into Uninett:master Sep 18, 2024
11 of 12 checks passed
@johannaengland johannaengland deleted the workflows/switch-to-megalinter branch September 18, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants