-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from super linter to mega linter #2941
Switch from super linter to mega linter #2941
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2941 +/- ##
=======================================
Coverage 56.37% 56.37%
=======================================
Files 602 602
Lines 43813 43813
Branches 48 48
=======================================
Hits 24700 24700
Misses 19101 19101
Partials 12 12 ☔ View full report in Codecov by Sentry. |
e54cac6
to
9250f7c
Compare
ce90141
to
e494181
Compare
e494181
to
371fa36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me. I'm not sure why we have flake8 config in tox.ini
and black in pyproject.toml
. Flake8 should really be moved to pyproject.toml
also, but since you're attempting to replace it with ruff, I'd wait for that instead :)
Flake8 does not support |
More info to the configuration of MegaLinter can be found here: https://megalinter.io/latest/configuration/
For example that
DEFAULT_BRANCH
has been deprecated.I noticed that flake8 was still throwing errors, possibly because it has never been run on the full codebase, only on changes, so I added two
#noqa
and added one template file to the files that are ignored by flake8.After approval I will set
VALIDATE_ALL_CODEBASE
to only do a full run on pushes to master, otherwise just linting the difference.