Add QR Code link to 'My Stuff' #2897
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
b46efd6
to
cda6a53
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2897 +/- ##
=======================================
Coverage 56.35% 56.36%
=======================================
Files 603 603
Lines 43862 43871 +9
Branches 48 48
=======================================
+ Hits 24719 24728 +9
Misses 19131 19131
Partials 12 12 ☔ View full report in Codecov by Sentry. |
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
3 times, most recently
from
02aea42
to
459cce4
Compare
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
2 times, most recently
from
10b84e2
to
f7aedce
Compare
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
f7aedce
to
667c376
Compare
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
a5951ec
to
667c376
Compare
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
667c376
to
03eb2d7
Compare
|
|
Clicking the link will show a page with a QR Code linking to the previous page
johannaengland
force-pushed
the
feature/qr-button-my-stuff
branch
from
03eb2d7
to
a0b810a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part to #2586.
This adds a button to 'My Stuff' that when clicked leads to a new page containing a QR Code that links to the page it was clicked from.
A new page is not what I want, I would prefer a pop up/overlay on the side the link is clicked at. But I tried and realized I don't have the necessary knowledge to do that on my own, so I decided to do this as a first draft with hopeful improvement by someone else/with guidance from someone else.
An idea that came from @lunkwill42 when discussing this was using htmx to accomplish this, but I was unable to get this to work. A possible resource for that: https://htmx.org/examples/modal-custom/
Screenshots - before and after
Before:
After: