Update PostgreSQL requirement to version 11 #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the current version of NAV may require no newer PostgreSQL syntax than 9.6, that version is hopelessly outdated (and newer Django versions we are considering moving to will not support PostgreSQLs this old). We also run mostly version 13 in production, and without this change, dumping and loading data from an actual production server just becomes that much harder (dump from PostgreSQL 13 don't seem to be compatible with 9.6).
Realistically, nothing in NAV uses any PostgreSQL syntax newer than version 9.6. However, this version of PostgreSQL has been EOL for many years, and we cannot even dump production data from modern PostgreSQL versions and expect to load them into our development installs by now. PostgreSQL 13 ought to be our target, but the next NAV release should still be able to run on Debian Buster, which means PostgreSQL 11 is the minimum. We can move to require PostgreSQL 13 in NAV 5.11.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2889 +/- ##
=======================================
Coverage 60.21% 60.21%
=======================================
Files 601 601
Lines 43981 43981
=======================================
Hits 26481 26481
Misses 17500 17500 ☔ View full report in Codecov by Sentry. |
johannaengland
approved these changes
May 2, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realistically, nothing in NAV currently uses any PostgreSQL syntax newer than version 9.6. However, this version of PostgreSQL has been EOL for many years, and we cannot even dump production data from modern PostgreSQL versions and expect to load them into our development installs by now. Also, we expect to update to a newer Django release soon, and Django has deprecated support for PostgreSQLs older than 12.
PostgreSQL 13 ought to be our target, but the next NAV release should still be able to run on Debian Buster, which means PostgreSQL 11 must be the minimum for this release. We can move to require PostgreSQL 13 in NAV 5.11.
This ensures that the dev environment will run PostgreSQL 13. The Docker test environment and the GitHub test environments should be running PostgreSQL 11 until the next feature release.