Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing NAV on Python 3.11 #2775

Closed
wants to merge 7 commits into from
Closed

Start testing NAV on Python 3.11 #2775

wants to merge 7 commits into from

Conversation

lunkwill42
Copy link
Member

@lunkwill42 lunkwill42 commented Nov 30, 2023

In preparation for #2788

Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

lunkwill42 and others added 7 commits February 29, 2024 14:47
We should've been testing for Python 3.10 for a long time now, it's
time to start!

fixxup
This attempts to ensure that the whole matrix isn't cancelled when
a single job fails.

Based on https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures
Can't remember why this restriction was put in there, but it seems it
prevents test results from being published when PR's repo is the same as
the origin.

Also don't understand or remember why the dependabot restriction is in
here. Removing that too.
We should've been testing for Python 3.11 for a long time now, it's
time to start!
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.15%. Comparing base (cdac0a5) to head (938f345).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2775      +/-   ##
==========================================
+ Coverage   57.14%   57.15%   +0.01%     
==========================================
  Files         567      567              
  Lines       41272    41278       +6     
==========================================
+ Hits        23586    23594       +8     
+ Misses      17686    17684       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmpf
Copy link
Contributor

hmpf commented Mar 1, 2024

Closing, replaced by #2838 and #2850, the latter of which is blocked by #2794

@hmpf hmpf closed this Mar 1, 2024
@hmpf hmpf deleted the test/python311 branch March 1, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants