Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isort in MegaLinter #872

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

johannaengland
Copy link
Contributor

Dependent on #868 and #869.

Up for discussion if we want to start using isort in Argus, I just thought it might be nice since we also use it in Zino.

@johannaengland johannaengland added discussion Requires developer feedback/discussion before implementation blocked Another thing/issue has to be resolved before tackling this labels Aug 30, 2024
@johannaengland johannaengland self-assigned this Aug 30, 2024
Copy link

sonarcloud bot commented Aug 30, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.17647% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.23%. Comparing base (4f8776e) to head (aeba60b).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/argus/notificationprofile/media/email.py 50.00% 2 Missing ⚠️
src/argus/ws/asgi.py 0.00% 2 Missing ⚠️
src/argus/notificationprofile/media/base.py 0.00% 1 Missing ⚠️
...rc/argus/notificationprofile/media/sms_as_email.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #872      +/-   ##
==========================================
- Coverage   84.29%   84.23%   -0.07%     
==========================================
  Files          86       86              
  Lines        3973     3945      -28     
==========================================
- Hits         3349     3323      -26     
+ Misses        624      622       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Another thing/issue has to be resolved before tackling this discussion Requires developer feedback/discussion before implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants