Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HTMx frontend #786

Closed
wants to merge 9 commits into from
Closed

Make HTMx frontend #786

wants to merge 9 commits into from

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Apr 23, 2024

For Uninett/argus-htmx-frontend#5

Master-branch for htmx experiment, do not merge!

@hmpf hmpf added help wanted Extra attention is needed HTMx Views, urls, templates... labels Apr 23, 2024
@hmpf
Copy link
Contributor Author

hmpf commented Apr 23, 2024

So far, this branch drags in another dependency and creates a base.html in argus/site/templates

Copy link

github-actions bot commented Apr 23, 2024

Test results

       7 files     574 suites   21m 39s ⏱️
   462 tests    461 ✔️ 1 💤 0
3 234 runs  3 227 ✔️ 7 💤 0

Results for commit d8fe2f9.

♻️ This comment has been updated with latest results.

* Add incidents page with replaceable rows
* Hook up htmx javascript from unpkg
* Split incident row into one template per column
* Add rudimentary incident details page
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 64.10256% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 84.39%. Comparing base (6488afa) to head (d3585b2).
Report is 2 commits behind head on master.

Files Patch % Lines
src/argus/htmx/views.py 44.44% 10 Missing ⚠️
...us/dev/management/commands/create_fake_incident.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     Uninett/Argus#786      +/-   ##
==========================================
- Coverage   84.61%   84.39%   -0.22%     
==========================================
  Files          75       78       +3     
  Lines        3750     3787      +37     
==========================================
+ Hits         3173     3196      +23     
- Misses        577      591      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@hmpf
Copy link
Contributor Author

hmpf commented Apr 29, 2024

HTMx dependencies and the htmx frontend app have been moved to https://github.com/Uninett/argus-htmx-frontend

Closing this PR.

@hmpf hmpf closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed HTMx Views, urls, templates...
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

HTMxify Argus
2 participants