Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ticket system docs #556

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Dec 12, 2022

Missing: a list of the finished plugins we already know of.

@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #556 (b8ebd45) into master (40e56b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #556   +/-   ##
=======================================
  Coverage   80.62%   80.62%           
=======================================
  Files          73       73           
  Lines        3504     3504           
=======================================
  Hits         2825     2825           
  Misses        679      679           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment on lines +9 to +12
Altering the link to a ticket
=============================

There are two ways to add the link:
Copy link
Contributor

@johannaengland johannaengland Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unclear here: Why is altering mentioned and next it says add?

``/api/v2/incidents/{incident_pk}/automatic-ticket/}`` will use the configured
ticket system plugin to create a ticket in the configured ticket system. The
resulting new URL is then automatically stored on the incident. To edit,
replace or remove this link, the endpoints in the previous section must be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
replace or remove this link, the endpoints in the previous section must be
replace or remove this link, the endpoints from the previous section must be

But that's just personal preference, not a must

Comment on lines 35 to 37
To enable this feature information needs to be added to the
:ref:`site-specific-settings`. How to do that for each ticket system plugin is
detailed in :ref:`ticket-systems-settings`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually not detailed there anymore, since we outsourced that to the separate plugins

Comment on lines +46 to +48
.. toctree::
ticket-systems/settings
ticket-systems/writing-ticket-system-plugins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels weird at the end of the page. We either should put it at the top or just link to it within the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants