Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define how incident relations should work #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Aug 19, 2021

Incident relations are under-specified and needs to be improved ahead of adding support for them in the frontend.

@hmpf hmpf added enhancement New feature or request data model Affects the data model and/or SQL schema API Affects Argus' REST API labels Aug 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #312 (56a2251) into master (ed099ad) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   70.61%   70.64%   +0.02%     
==========================================
  Files          64       64              
  Lines        2420     2422       +2     
==========================================
+ Hits         1709     1711       +2     
  Misses        711      711              
Impacted Files Coverage Δ
src/argus/incident/models.py 88.38% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed099ad...56a2251. Read the comment docs.

@hmpf hmpf force-pushed the improve-incident-relation branch from 56a2251 to bed11b3 Compare April 25, 2024 13:18
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Test results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit bed11b3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Affects Argus' REST API data model Affects the data model and/or SQL schema enhancement New feature or request rc-future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants