Test known paths #263
Draft
Test known paths #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmpf
force-pushed
the
test-known-paths
branch
2 times, most recently
from
8ba7e9b
to
b962949
Compare
|
The class is more or less copied/simplified from django-extensions show_urls and is overkill for this sole test. It's handy functionality to have around though, should perhaps live in a util library somewhere. (Well, should be available in Django proper but I digress.) |
lunkwill42
reviewed
Mar 2, 2021
Comment on lines
+110
to
+114
| def test_no_necessary_paths_should_be_missing(self): | ||
| installed_paths = set(UrlpatternFlattener().paths) | ||
| missing = NECESSARY_PATHS - installed_paths |
There was a problem hiding this comment.
Where's the assertion this test makes?
There was a problem hiding this comment.
Deffo needed and deffo missing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #261