Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pipeline dependencies #1250

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

fredrik-bakke
Copy link
Collaborator

@fredrik-bakke fredrik-bakke commented Jan 30, 2025

Due to deprecations with the GitHub API, some of our pipeline dependencies have started failing today, and more will tomorrow. I'm taking the opportunity do to some midwinter cleaning and updating all of our dependencies. Here's the homework I've done, from most to least important:

  • actions/upload-pages-artifact@v3 updates to upload-artifact@v4 (broke today) and removes a builtin chmod command we don't use
  • actions/deploy-pages@v4 updates to upload-artifact@v4 (broke today), updates to Node20
  • actions/cargo-install@v>=3.2 update to new GitHub API (otherwise breaks tomorrow)
  • actions/configure-pages@v5 swaps to Next.js 13.3 and newer, updates to Node20
  • actions/cache@v4 updates to Node20
  • actions/checkout@v4 updates to Node20
  • actions/actions-mdbook@v3 updates to Node20
  • actions/setup-python@v5 updates to Node20
  • pre-commit/[email protected] updates dependency to actions/cache@v4

Some input parameters have also been deprecated and removed, I don't know if this will affect us yet. Since there are no warnings in our CI logs that we are using deprecated input parameters, I'm assuming we're good on this front.

@fredrik-bakke
Copy link
Collaborator Author

The CI also yells at us for not updating mdbook submodules, but from what I can recall you telling me, the devs have a reputation for making breaking changes?

image

@VojtechStep
Copy link
Collaborator

The typechecking CI passes, so that looks good, and the only way to test deployment is to merge this, so go for it.

There were actual breaking changes that affect us in newer versions of mdbook, which IIRC some of the newer modules depend on, so I'd separate updating actions from updating mdbook.

@fredrik-bakke fredrik-bakke merged commit 41b9165 into UniMath:master Jan 30, 2025
4 checks passed
@fredrik-bakke fredrik-bakke deleted the fix-ci branch January 30, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants