-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Descent data for sequential colimits and its version of the flattening lemma #1109
Merged
fredrik-bakke
merged 11 commits into
UniMath:master
from
VojtechStep:feature/sequential-colimits-2
Apr 16, 2024
Merged
Descent data for sequential colimits and its version of the flattening lemma #1109
fredrik-bakke
merged 11 commits into
UniMath:master
from
VojtechStep:feature/sequential-colimits-2
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechStep
force-pushed
the
feature/sequential-colimits-2
branch
from
April 13, 2024 19:33
37531f3
to
2d3da21
Compare
fredrik-bakke
approved these changes
Apr 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely amazing work, well done! The infrastructure you're building is looking pristine
src/synthetic-homotopy-theory/cocones-under-sequential-diagrams.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/families-descent-data-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/families-descent-data-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/flattening-lemma-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/total-sequential-diagrams.lagda.md
Outdated
Show resolved
Hide resolved
VojtechStep
force-pushed
the
feature/sequential-colimits-2
branch
from
April 16, 2024 12:58
2d3da21
to
c800133
Compare
VojtechStep
force-pushed
the
feature/sequential-colimits-2
branch
from
April 16, 2024 13:16
c800133
to
690b8b2
Compare
VojtechStep
force-pushed
the
feature/sequential-colimits-2
branch
from
April 16, 2024 13:32
690b8b2
to
d2a1bd9
Compare
I looked over pentagons again, and the comments that were left unresolved, and it looks good to me now aside from the new comments I added |
Co-authored-by: Fredrik Bakke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, this is bigger than I anticipated...
This PR
I took care to properly separate the work into commits, so it might be more digestible to review it commit by commit.
This is progress towards #1080